Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Same filter can be applied multiple times #6219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kratosmy
Copy link
Contributor

What changes are being made and why?

closes #6028

How the changes have been QAed?

image

@kratosmy
Copy link
Contributor Author

@anna-geller could you please help review?

@MilosPaunovic MilosPaunovic self-requested a review November 30, 2024 08:33
@MilosPaunovic MilosPaunovic self-assigned this Nov 30, 2024
@anna-geller
Copy link
Member

I actually thought the way to implement it would be to make the namespace dropdown not available if one namespace filter has already been added

So more like disabling the filtering option instead of raising an error - WDYT? No strong opinions

For code review, Milos assigned himself 👍

@kratosmy
Copy link
Contributor Author

I actually thought the way to implement it would be to make the namespace dropdown not available if one namespace filter has already been added

So more like disabling the filtering option instead of raising an error - WDYT? No strong opinions

For code review, Milos assigned himself 👍

Good point, actually I didn't particularly consider the business context, but as you said, If multiple namespaces do not exist, disabling the filter should be better.

@MilosPaunovic
Copy link
Member

Actually, I think the best solution here would be to, if, for example, you already have a namespace filter selected, and considering the namespace filter has multiple: false, still allow the ability to choose the namespace but to replace the existing value. WDYT @anna-geller?

@anna-geller
Copy link
Member

Great idea Milos! 👍

@kratosmy
Copy link
Contributor Author

kratosmy commented Dec 2, 2024

Actually, I think the best solution here would be to, if, for example, you already have a namespace filter selected, and considering the namespace filter has multiple: false, still allow the ability to choose the namespace but to replace the existing value. WDYT @anna-geller?

@MilosPaunovic I agree. So will you do the implementation or let me finish it?

@MilosPaunovic
Copy link
Member

I'd definitely appreciate if you can tackle it @kratosmy!

@kratosmy
Copy link
Contributor Author

kratosmy commented Dec 2, 2024

I'd definitely appreciate if you can tackle it @kratosmy!

sure!

@MilosPaunovic
Copy link
Member

Hey @kratosmy, is this ready for review or you still haven't had the chance to work on the agreed specs?

@kratosmy
Copy link
Contributor Author

kratosmy commented Dec 5, 2024

Hey @kratosmy, is this ready for review or you still haven't had the chance to work on the agreed specs?

Hi , @MilosPaunovic , i am busy this week, i will be free on Sunday and continue my work.

@kratosmy kratosmy force-pushed the develop branch 4 times, most recently from 157751d to 0c36591 Compare December 10, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

Same filter can be applied multiple times
3 participants