-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Same filter can be applied multiple times #6219
base: develop
Are you sure you want to change the base?
Conversation
@anna-geller could you please help review? |
I actually thought the way to implement it would be to make the namespace dropdown not available if one namespace filter has already been added So more like disabling the filtering option instead of raising an error - WDYT? No strong opinions For code review, Milos assigned himself 👍 |
Good point, actually I didn't particularly consider the business context, but as you said, If multiple namespaces do not exist, disabling the filter should be better. |
Actually, I think the best solution here would be to, if, for example, you already have a namespace filter selected, and considering the namespace filter has |
Great idea Milos! 👍 |
@MilosPaunovic I agree. So will you do the implementation or let me finish it? |
I'd definitely appreciate if you can tackle it @kratosmy! |
sure! |
Hey @kratosmy, is this ready for review or you still haven't had the chance to work on the agreed specs? |
Hi , @MilosPaunovic , i am busy this week, i will be free on Sunday and continue my work. |
157751d
to
0c36591
Compare
What changes are being made and why?
closes #6028
How the changes have been QAed?